Fix test settings for proj (no googletest) #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Only build tests for proj package if required Even if tests are not explictly required to be built, proj build them anyway and tries to download Google Test. * proj: fix name of test activation flag * proj: Always set test activation flag * proj: Patch test activation logic for versions 5.x
AlexanderRichert-NOAA
changed the base branch from
develop
to
jcsda_emc_spack_stack
3 tasks
climbfuji
approved these changes
Jan 9, 2024
AlexanderRichert-NOAA
merged commit d003817
into
JCSDA:jcsda_emc_spack_stack
14 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR pulls in commit 013f0d3 from main Spack, which fixes the proj recipe by disabling the googletest-based tests when we're not using self.run_tests. This will allow us to install proj from source cache without an internet connection.
Issue(s) addressed
Address spack#934
Dependencies
none
Impact
none
Checklist